Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1402193003: Pad line number appropriately when generating script insets. (Closed)

Created:
5 years, 2 months ago by turnidge
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pad line number appropriately when generating script insets. This avoid jagged indentation when we jump from 9->10, 99->100, etc. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f5a07f6a9c393b8c5b9ed753672b773a6858d5a3

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 1 4 chunks +14 lines, -9 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 2 months ago (2015-10-14 18:39:39 UTC) #2
Cutch
LGTM with a small suggestion https://codereview.chromium.org/1402193003/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1402193003/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart#newcode962 runtime/observatory/lib/src/elements/script_inset.dart:962: var e = span("$nbsp${lineNumber.toString().padLeft(lineNumPad,nbsp)}$nbsp"); ...
5 years, 2 months ago (2015-10-14 19:12:41 UTC) #3
turnidge
https://codereview.chromium.org/1402193003/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1402193003/diff/20001/runtime/observatory/lib/src/elements/script_inset.dart#newcode962 runtime/observatory/lib/src/elements/script_inset.dart:962: var e = span("$nbsp${lineNumber.toString().padLeft(lineNumPad,nbsp)}$nbsp"); On 2015/10/14 19:12:41, Cutch wrote: ...
5 years, 2 months ago (2015-10-14 19:23:13 UTC) #4
turnidge
5 years, 2 months ago (2015-10-14 20:28:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f5a07f6a9c393b8c5b9ed753672b773a6858d5a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698