Pad line number appropriately when generating script insets.

runtime/observatory/lib/src/elements/script_inset.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library script_inset_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'service_ref.dart';
@@ skipping 806 matching lines @@
   }
 
   Element linesTable() {
     var table = new DivElement();
     table.classes.add("sourceTable");
 
     if (_startLine == null || _endLine == null) {
       return table;
     }
 
+    var endLine = (endPos != null
+                   ? script.tokenToLine(endPos)
+                   : script.lines.length + script.lineOffset);
+    var lineNumPad = endLine.toString().length;
+
     annotationsCursor = 0;
 
     int blankLineCount = 0;
     for (int i = _startLine; i <= _endLine; i++) {
       var line = script.getLine(i);
       if (line.isBlank) {
         // Try to introduce elipses if there are 4 or more contiguous
         // blank lines.
         blankLineCount++;
       } else {
         if (blankLineCount > 0) {
           int firstBlank = i - blankLineCount;
           int lastBlank = i - 1;
           if (blankLineCount < 4) {
             // Too few blank lines for an elipsis.
             for (int j = firstBlank; j  <= lastBlank; j++) {
-              table.append(lineElement(script.getLine(j)));
+              table.append(lineElement(script.getLine(j), lineNumPad));
             }
           } else {
             // Add an elipsis for the skipped region.
-            table.append(lineElement(script.getLine(firstBlank)));
-            table.append(lineElement(null));
-            table.append(lineElement(script.getLine(lastBlank)));
+            table.append(lineElement(script.getLine(firstBlank), lineNumPad));
+            table.append(lineElement(null, lineNumPad));
+            table.append(lineElement(script.getLine(lastBlank), lineNumPad));
           }
           blankLineCount = 0;
         }
-        table.append(lineElement(line));
+        table.append(lineElement(line, lineNumPad));
       }
     }
 
     return table;
   }
 
   // Assumes annotations are sorted.
   Annotation nextAnnotationOnLine(int line) {
     if (annotationsCursor >= annotations.length) return null;
     var annotation = annotations[annotationsCursor];
 
     // Fast-forward past any annotations before the first line that
     // we are displaying.
     while (annotation.line < line) {
       annotationsCursor++;
       if (annotationsCursor >= annotations.length) return null;
       annotation = annotations[annotationsCursor];
     }
 
     // Next annotation is for a later line, don't advance past it.
     if (annotation.line != line) return null;
     annotationsCursor++;
     return annotation;
   }
 
-  Element lineElement(ScriptLine line) {
+  Element lineElement(ScriptLine line, int lineNumPad) {
     var e = new DivElement();
     e.classes.add("sourceRow");
     e.append(lineBreakpointElement(line));
-    e.append(lineNumberElement(line));
+    e.append(lineNumberElement(line, lineNumPad));
     e.append(lineSourceElement(line));
     return e;
   }
 
   Element lineBreakpointElement(ScriptLine line) {
     var e = new DivElement();
     var busy = false;
     if (line == null || !line.possibleBpt) {
       e.classes.add("emptyBreakpoint");
       e.classes.add('noCopy');
@@ skipping 51 matching lines @@
           busy = false;
           update();
         });
       }
       update();
     });
     update();
     return e;
   }
 
-  Element lineNumberElement(ScriptLine line) {
+  Element lineNumberElement(ScriptLine line, int lineNumPad) {
     var lineNumber = line == null ? "..." : line.line;
-    var e = span("$nbsp$lineNumber$nbsp");
+    var e = span("$nbsp${lineNumber.toString().padLeft(lineNumPad,nbsp)}$nbsp");

[Cutch, 2015/10/14 19:12:41]

if (lineNumPad == null) {
  lineNumPad = 0;
}

[turnidge, 2015/10/14 19:23:13]

Resolved offline.

     e.classes.add('noCopy');
 
     if (lineNumber == _currentLine) {
       hitsCurrent(e);
     } else if ((line == null) || (line.hits == null)) {
       hitsUnknown(e);
     } else if (line.hits == 0) {
       hitsNotExecuted(e);
     } else {
       hitsExecuted(e);
@@ skipping 54 matching lines @@
 @CustomTag('source-inset')
 class SourceInsetElement extends PolymerElement {
   SourceInsetElement.created() : super.created();
 
   @published SourceLocation location;
   @published String height = null;
   @published int currentPos;
   @published bool inDebuggerContext = false;
   @published ObservableList variables;
 }