Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1402133003: Skip updating nodeUnderMouse to clickTarget. (Closed)

Created:
5 years, 2 months ago by mustaq
Modified:
5 years, 2 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip updating nodeUnderMouse to clickTarget. After a drag (mousedown-mousemove-mouseup) across an element border, chromium sends "click" event to the common ancestor of of mousedown & mouseup nodes. At that time, EventHandler::m_nodeUnderMouse was mistakenly updated to the common ancestor, resulting in redundant mouse node-transition events (mouseout/over/enter/leave) during & after the click. This CL skips updating nodeUnderMouse to fix the bug. BUG=356090 Committed: https://crrev.com/b729757fd10f845697c3028d5e41dbe4ce1295a0 Cr-Commit-Position: refs/heads/master@{#354519}

Patch Set 1 #

Patch Set 2 : Added a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/mouseenter-mouseleave-on-drag.html View 1 2 chunks +30 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/mouseenter-mouseleave-on-drag-expected.txt View 1 1 chunk +28 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402133003/1
5 years, 2 months ago (2015-10-14 15:45:43 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 17:22:48 UTC) #4
mustaq
ptal
5 years, 2 months ago (2015-10-14 17:55:40 UTC) #6
Rick Byers
Nice catch, LGTM
5 years, 2 months ago (2015-10-15 21:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402133003/20001
5 years, 2 months ago (2015-10-16 14:23:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 15:53:55 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 15:54:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b729757fd10f845697c3028d5e41dbe4ce1295a0
Cr-Commit-Position: refs/heads/master@{#354519}

Powered by Google App Engine
This is Rietveld 408576698