Refactoring DeviceCapabilities unit test.

[Chromecast] Capabilities do not get removed when Validators unregister.

Also removing capability value initialization from Register().
This is done separately now.

The unit tests were checking the internal dictionary to test the
result of capability changes. This is incorrect. They have
been changed to use the public GetCapability() accessor.

Also adding a GetValidator() method that is currently used
in unit tests but also can be useful in future for checking if
a Validator is currently registered for a capability.

TEST=cast_base_unittests
BUG=

Committed: https://crrev.com/179e89659c89c0f738286374e6084b77c8c82c14
Cr-Commit-Position: refs/heads/master@{#353945}

[esum, 2015-10-13 19:42:51]

esum@chromium.org changed reviewers:
+ byungchul@chromium.org, derekjchow@chromium.org, gunsch@chromium.org,
halliwell@chromium.org, maclellant@chromium.org

[esum, 2015-10-13 19:42:52]

Planned set of changes (each change is done in preparation for next):

1) Refactor unit tests and add GetValidator() method.
2) Change Unregister() to not remove capability from dictionary, and split
registration into Register(capability, validator) and then SetValidatedValue().
3) Downstream: Move DisplaySupportManager to ChromecastService.
4) Downstream: Move DeviceCapabilities ownership to DeviceInfo.

[byungchul, 2015-10-13 21:52:20]

On 2015/10/13 19:42:52, ericsum wrote:
> Planned set of changes (each change is done in preparation for next):
> 
> 1) Refactor unit tests and add GetValidator() method.
> 2) Change Unregister() to not remove capability from dictionary, and split
> registration into Register(capability, validator) and then
SetValidatedValue().
> 3) Downstream: Move DisplaySupportManager to ChromecastService.
> 4) Downstream: Move DeviceCapabilities ownership to DeviceInfo.

Why don't do 1) and 2) at a time?

[esum, 2015-10-13 21:57:02]

On 2015/10/13 21:52:20, byungchul wrote:
> On 2015/10/13 19:42:52, ericsum wrote:
> > Planned set of changes (each change is done in preparation for next):
> > 
> > 1) Refactor unit tests and add GetValidator() method.
> > 2) Change Unregister() to not remove capability from dictionary, and split
> > registration into Register(capability, validator) and then
> SetValidatedValue().
> > 3) Downstream: Move DisplaySupportManager to ChromecastService.
> > 4) Downstream: Move DeviceCapabilities ownership to DeviceInfo.
> 
> Why don't do 1) and 2) at a time?

I thought it might be easier to review if I do 2 smaller CL's.

But I can do them both if you'd like. Would that be better?

[esum, 2015-10-13 22:08:59]

On 2015/10/13 21:57:02, ericsum wrote:
> On 2015/10/13 21:52:20, byungchul wrote:
> > On 2015/10/13 19:42:52, ericsum wrote:
> > > Planned set of changes (each change is done in preparation for next):
> > > 
> > > 1) Refactor unit tests and add GetValidator() method.
> > > 2) Change Unregister() to not remove capability from dictionary, and split
> > > registration into Register(capability, validator) and then
> > SetValidatedValue().
> > > 3) Downstream: Move DisplaySupportManager to ChromecastService.
> > > 4) Downstream: Move DeviceCapabilities ownership to DeviceInfo.
> > 
> > Why don't do 1) and 2) at a time?
> 
> I thought it might be easier to review if I do 2 smaller CL's.
> 
> But I can do them both if you'd like. Would that be better?

Never mind. I'll just integrate 2) into this CL. Hold on review for Patch Set 2.

[esum, 2015-10-14 00:39:36]

On 2015/10/13 22:08:59, ericsum wrote:
> On 2015/10/13 21:57:02, ericsum wrote:
> > On 2015/10/13 21:52:20, byungchul wrote:
> > > On 2015/10/13 19:42:52, ericsum wrote:
> > > > Planned set of changes (each change is done in preparation for next):
> > > > 
> > > > 1) Refactor unit tests and add GetValidator() method.
> > > > 2) Change Unregister() to not remove capability from dictionary, and
split
> > > > registration into Register(capability, validator) and then
> > > SetValidatedValue().
> > > > 3) Downstream: Move DisplaySupportManager to ChromecastService.
> > > > 4) Downstream: Move DeviceCapabilities ownership to DeviceInfo.
> > > 
> > > Why don't do 1) and 2) at a time?
> > 
> > I thought it might be easier to review if I do 2 smaller CL's.
> > 
> > But I can do them both if you'd like. Would that be better?
> 
> Never mind. I'll just integrate 2) into this CL. Hold on review for Patch Set
2.

PatchSet 2 contains changes for 2) now. Ready for review. Thank you.

[byungchul, 2015-10-14 01:01:24]

lgtm

[halliwell, 2015-10-14 01:54:35]

On 2015/10/14 01:01:24, byungchul wrote:
> lgtm

rs-lgtm

[esum, 2015-10-14 01:55:22]

The CQ bit was checked by esum@chromium.org

[commit-bot: I haz the power, 2015-10-14 01:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1401993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1401993002/20001

[commit-bot: I haz the power, 2015-10-14 02:17:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-14 02:18:38]

Patchset 2 (id:??) landed as
https://crrev.com/179e89659c89c0f738286374e6084b77c8c82c14
Cr-Commit-Position: refs/heads/master@{#353945}