Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chromecast/base/device_capabilities_impl.h

Issue 1401993002: Refactoring DeviceCapabilities unit test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unregister() does not remove capability. Register() does not take initial value. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/device_capabilities.h ('k') | chromecast/base/device_capabilities_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/device_capabilities_impl.h
diff --git a/chromecast/base/device_capabilities_impl.h b/chromecast/base/device_capabilities_impl.h
index a0701ef2000c69287a8703827098214d8ff191b4..e58774cf088d51ed221fc4374cbb6ae5e943394e 100644
--- a/chromecast/base/device_capabilities_impl.h
+++ b/chromecast/base/device_capabilities_impl.h
@@ -17,10 +17,9 @@ class DeviceCapabilitiesImpl : public DeviceCapabilities {
~DeviceCapabilitiesImpl() override;
// DeviceCapabilities implementation:
- void Register(const std::string& key,
- scoped_ptr<base::Value> init_value,
- Validator* validator) override;
+ void Register(const std::string& key, Validator* validator) override;
void Unregister(const std::string& key, const Validator* validator) override;
+ Validator* GetValidator(const std::string& key) const override;
bool BluetoothSupported() const override;
bool DisplaySupported() const override;
bool GetCapability(const std::string& path,
@@ -48,8 +47,6 @@ class DeviceCapabilitiesImpl : public DeviceCapabilities {
void SetValidatedValueInternal(const std::string& path,
scoped_ptr<base::Value> new_value) override;
-
- void AddValidator(const std::string& key, Validator* validator);
void UpdateStrAndNotifyChanged(const std::string& path);
scoped_ptr<base::DictionaryValue> capabilities_;
« no previous file with comments | « chromecast/base/device_capabilities.h ('k') | chromecast/base/device_capabilities_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698