Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1401863002: Stop handling neutral keyframes in CSSValueInterpolationType (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 2 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_fixCSSValueInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop handling neutral keyframes in CSSValueInterpolationType Small clean up patch that makes CSSValueInterpolationType no longer handle neutral values. This lets certain property specific neutral keyframes convert as nullptr and skip being applied. Committed: https://crrev.com/61517d4a243fe1a7cd0b158bc1459e82307be75e Cr-Commit-Position: refs/heads/master@{#353935}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-13 06:56:39 UTC) #2
dstockwell
lgtm
5 years, 2 months ago (2015-10-13 07:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401863002/20001
5 years, 2 months ago (2015-10-14 00:09:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 01:17:31 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 01:18:24 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61517d4a243fe1a7cd0b158bc1459e82307be75e
Cr-Commit-Position: refs/heads/master@{#353935}

Powered by Google App Engine
This is Rietveld 408576698