Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 14018007: Rename RandomAccessFile.readList and RandomAccessFile.writeList to RandomAccessFile.readInto and Ra… (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename RandomAccessFile.readList and RandomAccessFile.writeList to RandomAccessFile.readInto and RandomAccessFile.writeFrom. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21466

Patch Set 1 #

Patch Set 2 : Fix return type. #

Total comments: 8

Patch Set 3 : Fixed comment and added test. #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -232 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/file.cc View 1 2 3 8 chunks +29 lines, -28 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tools/mini_parser.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/common.dart View 1 2 3 3 chunks +11 lines, -10 lines 0 comments Download
M sdk/lib/io/file.dart View 1 2 3 chunks +28 lines, -20 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 3 5 chunks +64 lines, -66 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_error_test.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 24 chunks +77 lines, -38 lines 0 comments Download
M tests/standalone/io/file_typed_data_test.dart View 1 2 3 9 chunks +17 lines, -17 lines 0 comments Download
M tests/standalone/io/read_into_const_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/lib/file_system_vm.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-15 13:30:43 UTC) #1
Søren Gjesse
LGTM, thanks Maybe add a test where only start is specified. https://codereview.chromium.org/14018007/diff/3001/sdk/lib/io/file.dart File sdk/lib/io/file.dart (right): ...
7 years, 8 months ago (2013-04-15 13:48:44 UTC) #2
Anders Johnsen
https://codereview.chromium.org/14018007/diff/3001/sdk/lib/io/file.dart File sdk/lib/io/file.dart (right): https://codereview.chromium.org/14018007/diff/3001/sdk/lib/io/file.dart#newcode373 sdk/lib/io/file.dart:373: * 0. If [end] is present, the [buffer] will ...
7 years, 8 months ago (2013-04-15 15:37:05 UTC) #3
Anders Johnsen
7 years, 8 months ago (2013-04-15 15:45:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r21466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698