SkPDF: fall back on paths for unembeddable fonts.

SkPDF: fall back on paths for unembeddable fonts.

Add GM, SkPDFFont::CanEmbedTypeface

BUG=skia:3866
Committed: https://skia.googlesource.com/skia/+/66a82f3872abf4ebb98b3915b2a9ecc73ad352c5

[hal.canary, 2015-10-12 18:24:57]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2015-10-12 18:24:57]

PTAL

[hal.canary, 2015-10-12 18:25:47]

On 2015/10/12 18:24:57, Hal Canary wrote:
> PTAL

Se also https://codereview.chromium.org/1157163007

[bungeman-skia, 2015-10-12 19:05:29]

How big is this roboto file? Should we at least sub-set it?

https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:1242:
SkASSERT(SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
I'm not sure it's enough to just debug assert this, since if the default font
isn't embedded-able, this would be bad. Here I think it turns into an infinite
loop?

[hal.canary, 2015-10-12 19:10:25]

https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:1242:
SkASSERT(SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
On 2015/10/12 19:05:29, bungeman1 wrote:
> I'm not sure it's enough to just debug assert this, since if the default font
> isn't embedded-able, this would be bad. Here I think it turns into an infinite
> loop?

this:

    SK_ALWAYSBREAK(SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
                                               device->getCanon()));

or this?

    if (!SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
                                     device->getCanon())) {
        SkDEBUGFAIL("default typeface should be embeddable");
        return;
    }

[hal.canary, 2015-10-12 19:20:14]

On 2015/10/12 19:05:29, bungeman1 wrote:
> How big is this roboto file? Should we at least sub-set it?


Already subseted.  6k.

[hal.canary, 2015-10-12 19:24:31]

On 2015/10/12 19:10:25, Hal Canary wrote:
> https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp
> File src/pdf/SkPDFDevice.cpp (right):
> 
>
https://codereview.chromium.org/1401763002/diff/1/src/pdf/SkPDFDevice.cpp#new...
> src/pdf/SkPDFDevice.cpp:1242:
> SkASSERT(SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
> On 2015/10/12 19:05:29, bungeman1 wrote:
> > I'm not sure it's enough to just debug assert this, since if the default
font
> > isn't embedded-able, this would be bad. Here I think it turns into an
infinite
> > loop?
> 
> this:
> 
>     SK_ALWAYSBREAK(SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
>                                                device->getCanon()));
> 
> or this?
> 
>     if (!SkPDFFont::CanEmbedTypeface(transparent.getTypeface(),
>                                      device->getCanon())) {
>         SkDEBUGFAIL("default typeface should be embeddable");
>         return;
>     }

done

[bungeman-skia, 2015-10-12 19:26:30]

https://codereview.chromium.org/1401763002/diff/20001/gm/pdf_never_embed.cpp
File gm/pdf_never_embed.cpp (right):

https://codereview.chromium.org/1401763002/diff/20001/gm/pdf_never_embed.cpp#...
gm/pdf_never_embed.cpp:31: SkDebugf("Missing resource: %s", resource);
GetResourceAsTypeface will already print

SkDebugf("Resource %s not found.\n", resource);

https://codereview.chromium.org/1401763002/diff/20001/tests/PDFPrimitivesTest...
File tests/PDFPrimitivesTest.cpp (right):

https://codereview.chromium.org/1401763002/diff/20001/tests/PDFPrimitivesTest...
tests/PDFPrimitivesTest.cpp:427:
GetResourceAsTypeface("Roboto2-Regular_NoEmbed.ttf"));
update location?

[hal.canary, 2015-10-12 19:48:24]

https://codereview.chromium.org/1401763002/diff/20001/gm/pdf_never_embed.cpp
File gm/pdf_never_embed.cpp (right):

https://codereview.chromium.org/1401763002/diff/20001/gm/pdf_never_embed.cpp#...
gm/pdf_never_embed.cpp:31: SkDebugf("Missing resource: %s", resource);
On 2015/10/12 19:26:30, bungeman1 wrote:
> GetResourceAsTypeface will already print
> 
> SkDebugf("Resource %s not found.\n", resource);

Done.

https://codereview.chromium.org/1401763002/diff/20001/tests/PDFPrimitivesTest...
File tests/PDFPrimitivesTest.cpp (right):

https://codereview.chromium.org/1401763002/diff/20001/tests/PDFPrimitivesTest...
tests/PDFPrimitivesTest.cpp:427:
GetResourceAsTypeface("Roboto2-Regular_NoEmbed.ttf"));
On 2015/10/12 19:26:30, bungeman1 wrote:
> update location?

Done.

[bungeman-skia, 2015-10-12 19:50:48]

lgtm

[hal.canary, 2015-10-12 19:51:04]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-10-12 19:51:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1401763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1401763002/40001

[commit-bot: I haz the power, 2015-10-12 19:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 19:52:15]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[hal.canary, 2015-10-12 19:55:04]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 19:55:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1401763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1401763002/60001

[hal.canary, 2015-10-12 20:02:10]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-10-12 20:04:12]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-10-12 20:04:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1401763002/#ps60001
(title: "2015-10-12 (Monday) 15:54:45 EDT")

[commit-bot: I haz the power, 2015-10-12 20:04:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1401763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1401763002/60001

[commit-bot: I haz the power, 2015-10-12 20:05:10]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/66a82f3872abf4ebb98b3915b2a9ecc73ad352c5