SkPDF: fall back on paths for unembeddable fonts.

SkPDF: fall back on paths for unembeddable fonts.

Add GM, SkPDFFont::CanEmbedTypeface

BUG=skia:3866

[hal.canary, 2015-06-08 17:25:40]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 17:26:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/20001

[hal.canary, 2015-06-08 17:26:35]

halcanary@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[hal.canary, 2015-06-08 17:26:55]

Patchset #1 (id:1) has been deleted

[hal.canary, 2015-06-08 17:28:21]

Patchset #1 (id:20001) has been deleted

[hal.canary, 2015-06-08 17:28:29]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 17:28:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/40001

[hal.canary, 2015-06-08 17:28:42]

PTAL

[commit-bot: I haz the power, 2015-06-08 17:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-08 17:32:55]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2015-06-08 17:43:45]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 17:44:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/60001

[bungeman-skia, 2015-06-08 17:46:47]

https://codereview.chromium.org/1157163007/diff/40001/gm/pdf_never_embed.cpp
File gm/pdf_never_embed.cpp (right):

https://codereview.chromium.org/1157163007/diff/40001/gm/pdf_never_embed.cpp#...
gm/pdf_never_embed.cpp:13: SkString font =
GetResourcePath("Roboto2-Regular_NoEmbed.ttf");
I think you want

SkAutoTUnref<SkTypeface> t(GetResourceAsTypeface("...");

https://codereview.chromium.org/1157163007/diff/40001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/1157163007/diff/40001/src/pdf/SkPDFDevice.cpp...
src/pdf/SkPDFDevice.cpp:1223: void SkPDFDevice::drawPosText(const SkDraw& d,
const void* text, size_t len,
I think this is the call generally used by Chromium.

https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp#n...
src/pdf/SkPDFFont.cpp:1435: face->getAdvancedTypefaceMetrics(info, NULL));
This is a really heavy call to get effectively two bits of information. Is this
not already known (someone already called getAdvancedTypefaceMetrics)?

[commit-bot: I haz the power, 2015-06-08 17:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-08 17:49:57]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-06-08 17:54:36]

https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp#n...
src/pdf/SkPDFFont.cpp:1435: face->getAdvancedTypefaceMetrics(info, NULL));
On 2015/06/08 17:46:47, bungeman1 wrote:
> This is a really heavy call to get effectively two bits of information. Is
this
> not already known (someone already called getAdvancedTypefaceMetrics)?

Now that I know that it is a heavy call, I can push this until later when it has
already been called.

[hal.canary, 2015-07-08 20:19:56]

On 2015/06/08 17:54:36, Hal Canary wrote:
> https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp
> File src/pdf/SkPDFFont.cpp (right):
> 
>
https://codereview.chromium.org/1157163007/diff/60001/src/pdf/SkPDFFont.cpp#n...
> src/pdf/SkPDFFont.cpp:1435: face->getAdvancedTypefaceMetrics(info, NULL));
> On 2015/06/08 17:46:47, bungeman1 wrote:
> > This is a really heavy call to get effectively two bits of information. Is
> this
> > not already known (someone already called getAdvancedTypefaceMetrics)?
> 
> Now that I know that it is a heavy call, I can push this until later when it
has
> already been called.

Hmm.  Harder than I thought.  It looks like we need a cheap
SkTypeface::canEmbed().

[hal.canary, 2015-07-14 21:55:58]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-14 21:56:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/120001

[hal.canary, 2015-07-15 13:39:49]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 13:39:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/140001

[commit-bot: I haz the power, 2015-07-15 13:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 13:43:26]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2015-07-15 14:06:09]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 14:06:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/160001

[commit-bot: I haz the power, 2015-07-15 14:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 14:09:56]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[hal.canary, 2015-07-15 14:13:23]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 14:13:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157163007/180001

[commit-bot: I haz the power, 2015-07-15 14:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 14:28:55]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-07-15 14:59:08]

On 2015/07/15 14:28:55, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Ben, can you comment on the current state of the code?

[bungeman-skia, 2015-07-15 18:09:01]

https://codereview.chromium.org/1157163007/diff/180001/src/ports/SkFontHost_w...
File src/ports/SkFontHost_win.cpp (right):

https://codereview.chromium.org/1157163007/diff/180001/src/ports/SkFontHost_w...
src/ports/SkFontHost_win.cpp:1764: 
I think onGetFamilyName above is a little more sane:

bool LogFontTypeface::onCanEmbed() const {
    HFONT font = CreateFontIndirect(&fLogFont);

    HDC hdc = CreateCompatibleDC(NULL);
    HFONT savefont = (HFONT)SelectObject(hdc, font);

    OUTLINETEXTMETRIC otm;
    UINT otmIsValid = GetOutlineTextMetrics(hdc, sizeof(otm), &otm);
    if (!otmIsValid) {
        call_ensure_accessible(lf);
        otmIsValid = GetOutlineTextMetrics(hdc, sizeof(otm), &otm);
    }
    bool canEmbed = false;
    if (otmIsValid) {
        // If bit 1 is set, the font may not be embedded in a document.
        canEmbed = (0 == (otm.otmfsType & 0x1));
    }

    if (hdc) {
        ::SelectObject(hdc, savefont);
        ::DeleteDC(deviceContext);
    }
    if (font) {
        ::DeleteObject(font);
    }

    return canEmbed;
}