Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401643002: Remove isolate parameter when allocating handles (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove isolate parameter when allocating handles BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5039117f5027f5cf47441ff7ccd85ba23da35995

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Remove isolate parameter from handle allocation #

Patch Set 4 : Synced #

Patch Set 5 : f #

Patch Set 6 : Final part of handles cleanup. #

Total comments: 1

Patch Set 7 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -399 lines) Patch
M runtime/vm/bootstrap.cc View 1 2 7 chunks +30 lines, -26 lines 0 comments Download
M runtime/vm/coverage.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/coverage.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/coverage_test.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 87 chunks +223 lines, -205 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 5 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 2 2 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 22 chunks +51 lines, -46 lines 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 2 12 chunks +23 lines, -23 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 chunks +0 lines, -24 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 16 chunks +33 lines, -25 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 4 5 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 2 months ago (2015-10-12 21:37:32 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1401643002/diff/100001/runtime/vm/object.h File runtime/vm/object.h (left): https://chromiumcodereview.appspot.com/1401643002/diff/100001/runtime/vm/object.h#oldcode68 runtime/vm/object.h:68: /* DEPRECATED: Use Zone version. */ \ Woo!
5 years, 2 months ago (2015-10-12 22:47:52 UTC) #3
srdjan
5 years, 2 months ago (2015-10-12 22:51:24 UTC) #4
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
5039117f5027f5cf47441ff7ccd85ba23da35995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698