Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: runtime/vm/coverage_test.cc

Issue 1401643002: Remove isolate parameter when allocating handles (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Sync Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/coverage.cc ('k') | runtime/vm/dart_api_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/coverage_test.cc
diff --git a/runtime/vm/coverage_test.cc b/runtime/vm/coverage_test.cc
index 92a98cd9a84c98e49dd506d0313164dba06a1e8d..1a2b0ebbab6196281d62e62327d06ac1d10b006f 100644
--- a/runtime/vm/coverage_test.cc
+++ b/runtime/vm/coverage_test.cc
@@ -39,13 +39,12 @@ TEST_CASE(Coverage_Empty) {
"main() {\n"
"}";
- Isolate* isolate = Isolate::Current();
Library& lib = Library::Handle();
lib ^= ExecuteScript(kScript);
ASSERT(!lib.IsNull());
JSONStream js;
- CodeCoverage::PrintJSON(isolate, &js, NULL, false);
+ CodeCoverage::PrintJSON(thread, &js, NULL, false);
char buf[1024];
OS::SNPrint(buf, sizeof(buf),
@@ -72,13 +71,12 @@ TEST_CASE(Coverage_MainWithClass) {
" foo.bar();\n"
"}\n";
- Isolate* isolate = Isolate::Current();
Library& lib = Library::Handle();
lib ^= ExecuteScript(kScript);
ASSERT(!lib.IsNull());
JSONStream js;
- CodeCoverage::PrintJSON(isolate, &js, NULL, false);
+ CodeCoverage::PrintJSON(thread, &js, NULL, false);
char buf[1024];
// Coverage data is printed per class, i.e., there should be two sections
@@ -115,7 +113,6 @@ TEST_CASE(Coverage_FilterFunction) {
" var foo = new Foo(7);\n"
"}\n";
- Isolate* isolate = Isolate::Current();
Library& lib = Library::Handle();
lib ^= ExecuteScript(kScript);
ASSERT(!lib.IsNull());
@@ -128,7 +125,7 @@ TEST_CASE(Coverage_FilterFunction) {
JSONStream js;
FunctionCoverageFilter filter(func);
- CodeCoverage::PrintJSON(isolate, &js, &filter, false);
+ CodeCoverage::PrintJSON(thread, &js, &filter, false);
// Only expect coverage data for Foo.yetAnother() on line 6.
char buf[1024];
OS::SNPrint(buf, sizeof(buf),
« no previous file with comments | « runtime/vm/coverage.cc ('k') | runtime/vm/dart_api_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698