Issue 1401553002: NOT INTENDED FOR LANDING: A promises demo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401553002: NOT INTENDED FOR LANDING: A promises demo (Closed)

Created:
5 years, 2 months ago by alex clarke (OOO till 29th)

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews, scheduler-bugs_chromium.org, robliao

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

NOT INTENDED FOR LANDING: A promises demo BUG=

Patch Set 2 : Use template varargs instead #

Patch Set 3 : Refactor executor #

Patch Set 4 : Fix cancellation #

Patch Set 5 : Couple of more tests #

Patch Set 6 : Added a SingleThreadPromiseExecutor #

Patch Set 7 : Closer to js syntax #

Patch Set 8 : Implemented Any().Then() #

Patch Set 9 : Refactor to create promises without an executor #

Patch Set 10 : Move Create, Any, All into a namespace #

Patch Set 11 : Support for manually resolving a promise with a promise #

Patch Set 12 : Major simplification #

Patch Set 13 : Add a couple of tests #

Patch Set 14 : Further simplification plus some template magic to enable static_asserts for Any() and All() #

Patch Set 15 : Hide the scoped_refptr #

Patch Set 16 : Support for rejectatble promises! #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4233 lines, -0 lines)			Patch
M	components/components_tests.gyp	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/scheduler/BUILD.gn	View	1 2 3 4 5 6 7	2 chunks	+11 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+257 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+202 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise_executor.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+57 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise_executor.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+86 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise_internal.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+529 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/promise_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+1198 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/rejectable.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+230 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/single_thread_promise_executor.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+38 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/single_thread_promise_executor.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+49 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/single_thread_promise_executor_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+934 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/template_helpers.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+101 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/thread_pool_promise_executor.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+36 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/thread_pool_promise_executor.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+57 lines, -0 lines	0 comments	Download
A	components/scheduler/promises/thread_pool_promise_executor_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+437 lines, -0 lines	0 comments	Download
M	components/scheduler/scheduler.gypi	View	1 2 3 4 5 6 7	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401553002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401553002/300001

4 years, 8 months ago (2016-04-15 12:16:22 UTC) #2

commit-bot: I haz the power

4 years, 8 months ago (2016-04-15 12:24:21 UTC) #4

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages