Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 1401423003: Re-land: ui: Move GLImage::BindTexImage fallback from GLImage implementations to GLES2CmdDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix stream texture issue Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index b78a5dcb6bc8976fdda9da4eb4c7e02aa6cd0887..2460a1eb6226f9098c3588fb5a39cf281b109bfd 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -87,8 +87,6 @@ class RenderbufferAttachment
renderbuffer_->AddToSignature(signature);
}
- void OnWillRenderTo() const override {}
- void OnDidRenderTo() const override {}
bool FormsFeedbackLoop(TextureRef* /* texture */,
GLint /*level */) const override {
return false;
@@ -179,7 +177,6 @@ class TextureAttachment
void DetachFromFramebuffer(Framebuffer* framebuffer) const override {
texture_ref_->texture()->DetachFromFramebuffer();
- framebuffer->OnTextureRefDetached(texture_ref_.get());
}
bool ValidForAttachmentType(GLenum attachment_type,
@@ -214,14 +211,6 @@ class TextureAttachment
texture_ref_.get(), target_, level_, signature);
}
- void OnWillRenderTo() const override {
- texture_ref_->texture()->OnWillModifyPixels();
- }
-
- void OnDidRenderTo() const override {
- texture_ref_->texture()->OnDidModifyPixels();
- }
-
bool FormsFeedbackLoop(TextureRef* texture, GLint level) const override {
return texture == texture_ref_.get() && level == level_;
}
@@ -238,10 +227,6 @@ class TextureAttachment
DISALLOW_COPY_AND_ASSIGN(TextureAttachment);
};
-FramebufferManager::TextureDetachObserver::TextureDetachObserver() {}
-
-FramebufferManager::TextureDetachObserver::~TextureDetachObserver() {}
-
FramebufferManager::FramebufferManager(
uint32 max_draw_buffers,
uint32 max_color_attachments,
@@ -713,28 +698,6 @@ const Framebuffer::Attachment* Framebuffer::GetReadBufferAttachment() const {
return GetAttachment(read_buffer_);
}
-void Framebuffer::OnTextureRefDetached(TextureRef* texture) {
- manager_->OnTextureRefDetached(texture);
-}
-
-void Framebuffer::OnWillRenderTo(GLenum attachment) const {
- for (AttachmentMap::const_iterator it = attachments_.begin();
- it != attachments_.end(); ++it) {
- if (attachment == 0 || attachment == it->first) {
- it->second->OnWillRenderTo();
- }
- }
-}
-
-void Framebuffer::OnDidRenderTo(GLenum attachment) const {
- for (AttachmentMap::const_iterator it = attachments_.begin();
- it != attachments_.end(); ++it) {
- if (attachment == 0 || attachment == it->first) {
- it->second->OnDidRenderTo();
- }
- }
-}
-
bool FramebufferManager::GetClientId(
GLuint service_id, GLuint* client_id) const {
// This doesn't need to be fast. It's only used during slow queries.
@@ -772,15 +735,5 @@ bool FramebufferManager::IsComplete(
framebuffer_state_change_count_;
}
-void FramebufferManager::OnTextureRefDetached(TextureRef* texture) {
- for (TextureDetachObserverVector::iterator it =
- texture_detach_observers_.begin();
- it != texture_detach_observers_.end();
- ++it) {
- TextureDetachObserver* observer = *it;
- observer->OnTextureRefDetachedFromFramebuffer(texture);
- }
-}
-
} // namespace gles2
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698