Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issue 1401243003: Add methods to extras' InternalPackedArray (Closed)

Created:
5 years, 2 months ago by domenic
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add methods to extras' InternalPackedArray https://codereview.chromium.org/1343113003 introduced a separate InternalPackedArray constructor to the extras utils object, distinct from the one used by natives. However, it omitted the code to set up the methods for that InternalPackedArray. This makes all the basic manipulation methods available. BUG=v8:4276 LOG=Y R=jochen@chromium.org,yangguo@chromium.org Committed: https://crrev.com/8f8457d2a414b1cdad6dc3cecff062a8ff5649cb Cr-Commit-Position: refs/heads/master@{#31272}

Patch Set 1 #

Patch Set 2 : Fix test typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M src/js/array.js View 2 chunks +12 lines, -1 line 0 comments Download
M test/cctest/test-extra.js View 1 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
Open to alternate suggestions on how to approach this (e.g. use the same InternalPackedArray for ...
5 years, 2 months ago (2015-10-13 22:08:07 UTC) #1
Yang
On 2015/10/13 22:08:07, domenic wrote: > Open to alternate suggestions on how to approach this ...
5 years, 2 months ago (2015-10-14 13:33:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401243003/20001
5 years, 2 months ago (2015-10-14 15:52:17 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 17:40:50 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 17:41:04 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f8457d2a414b1cdad6dc3cecff062a8ff5649cb
Cr-Commit-Position: refs/heads/master@{#31272}

Powered by Google App Engine
This is Rietveld 408576698