Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1343113003: Implement V8 extras utils object (Closed)

Created:
5 years, 3 months ago by domenic
Modified:
5 years, 3 months ago
CC:
majidvp, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement V8 extras utils object This adds a utils object meant specifically for V8 extras, presenting a limited API surface for doing things that would otherwise require %-functions. BUG=v8:4276 LOG=Y R=jochen@chromium.org,yangguo@chromium.org Committed: https://crrev.com/d346834fdc39da0588cd26fed7fa8d53c321032f Cr-Commit-Position: refs/heads/master@{#30773}

Patch Set 1 #

Patch Set 2 : Comment fix #

Total comments: 1

Patch Set 3 : Remove call/apply helpers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -9 lines) Patch
M src/bootstrapper.cc View 1 5 chunks +17 lines, -5 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/prologue.js View 1 2 2 chunks +46 lines, -1 line 0 comments Download
M src/promise.js View 2 chunks +10 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/test-extra.js View 1 2 1 chunk +42 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
domenic
If this looks good, I can work on a subsequent patch to disable %-function access ...
5 years, 3 months ago (2015-09-15 19:20:54 UTC) #1
jochen (gone - plz use gerrit)
looks good, but really, we should wait for Yang
5 years, 3 months ago (2015-09-16 11:24:08 UTC) #2
domenic
jkummerow@, Jochen suggested you might be a good reviewer in lieu of Yang since he's ...
5 years, 3 months ago (2015-09-16 14:29:37 UTC) #4
Yang
https://codereview.chromium.org/1343113003/diff/20001/src/prologue.js File src/prologue.js (right): https://codereview.chromium.org/1343113003/diff/20001/src/prologue.js#newcode302 src/prologue.js:302: return %Apply(func, thisArg, arguments, 2, arguments.length - 2); %Apply ...
5 years, 3 months ago (2015-09-16 18:41:34 UTC) #5
domenic
On 2015/09/16 at 18:41:34, yangguo wrote: > https://codereview.chromium.org/1343113003/diff/20001/src/prologue.js > File src/prologue.js (right): > > https://codereview.chromium.org/1343113003/diff/20001/src/prologue.js#newcode302 ...
5 years, 3 months ago (2015-09-16 18:48:17 UTC) #6
domenic
On 2015/09/16 at 18:48:17, domenic wrote: > You're right, the extra utilities I provided here ...
5 years, 3 months ago (2015-09-16 19:55:28 UTC) #7
Yang
On 2015/09/16 19:55:28, domenic wrote: > On 2015/09/16 at 18:48:17, domenic wrote: > > > ...
5 years, 3 months ago (2015-09-16 20:04:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343113003/40001
5 years, 3 months ago (2015-09-16 20:16:42 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 20:42:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343113003/40001
5 years, 3 months ago (2015-09-16 20:59:14 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-16 21:00:52 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 21:01:05 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d346834fdc39da0588cd26fed7fa8d53c321032f
Cr-Commit-Position: refs/heads/master@{#30773}

Powered by Google App Engine
This is Rietveld 408576698