Issue 140123003: Escape 'gomadir' for GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140123003: Escape 'gomadir' for GN. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Escape 'gomadir' for GN. No real functionality change (except for people who have " or $ in their gomadir, but since that didn't work up until this change nobody does that). R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245799

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/gyp_chromium	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/140123003/1

6 years, 11 months ago (2014-01-18 22:14:08 UTC) #3

Nico

6 years, 11 months ago (2014-01-18 23:50:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r245799 (presubmit successful).