build/gyp_chromium - Issue 140123003: Escape 'gomadir' for GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 140123003: Escape 'gomadir' for GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index 3ee04aab52ccbc4d0e2744bbbab81eb7b1acde50..8e841d46bd1bbc9024ffb0e4d59d579d316496f5 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -207,7 +207,7 @@ def GetArgsStringForGN(supplemental_files):

# gomadir is renamed goma_dir in the GN build.

if 'gomadir' in vars_dict:

- gn_args += ' goma_dir="%s"' % vars_dict['gomadir']

+ gn_args += ' goma_dir=%s' % EscapeStringForGN(vars_dict['gomadir'])

# These arguments get passed directly as integers (avoiding the quoting and

# escaping of the string ones above).

« no previous file with comments | « no previous file | no next file » | no next file with comments »