Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401173003: [heap] Reland decrease large object limit for regular heap objects. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland decrease large object limit for regular heap objects. BUG= Committed: https://crrev.com/9b91bf3a630b5382080ba1d7f9f3e88de3de8a95 Cr-Commit-Position: refs/heads/master@{#31228}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M src/heap/mark-compact.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M src/heap/scavenger.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +8 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Hannes Payer (out of office)
Getting the dchecks right.
5 years, 2 months ago (2015-10-12 19:44:39 UTC) #2
Michael Lippautz
lgtm w/ a nit https://codereview.chromium.org/1401173003/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1401173003/diff/20001/src/heap/mark-compact.cc#newcode2669 src/heap/mark-compact.cc:2669: DCHECK(size); nit: remove or make ...
5 years, 2 months ago (2015-10-13 07:42:26 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1401173003/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1401173003/diff/20001/src/heap/mark-compact.cc#newcode2669 src/heap/mark-compact.cc:2669: DCHECK(size); On 2015/10/13 07:42:26, Michael Lippautz wrote: > nit: ...
5 years, 2 months ago (2015-10-13 08:20:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401173003/40001
5 years, 2 months ago (2015-10-13 08:20:54 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-13 08:43:06 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9b91bf3a630b5382080ba1d7f9f3e88de3de8a95 Cr-Commit-Position: refs/heads/master@{#31228}
5 years, 2 months ago (2015-10-13 08:43:36 UTC) #9
Hannes Payer (out of office)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1395653003/ by hpayer@chromium.org. ...
5 years, 2 months ago (2015-10-13 13:46:44 UTC) #10
Michael Achenbach
5 years, 2 months ago (2015-10-13 19:35:35 UTC) #11
Message was sent while issue was closed. 
Maybe also this is useful:
https://cluster-fuzz.appspot.com/testcase?key=5647101969563648

Powered by Google App Engine
This is Rietveld 408576698