Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: test/cctest/test-spaces.cc

Issue 1401173003: [heap] Reland decrease large object limit for regular heap objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 CHECK(compaction_space->SetUp()); 423 CHECK(compaction_space->SetUp());
424 424
425 OldSpace* old_space = new OldSpace(heap, OLD_SPACE, NOT_EXECUTABLE); 425 OldSpace* old_space = new OldSpace(heap, OLD_SPACE, NOT_EXECUTABLE);
426 CHECK(old_space != NULL); 426 CHECK(old_space != NULL);
427 CHECK(old_space->SetUp()); 427 CHECK(old_space->SetUp());
428 428
429 // Cannot loop until "Available()" since we initially have 0 bytes available 429 // Cannot loop until "Available()" since we initially have 0 bytes available
430 // and would thus neither grow, nor be able to allocate an object. 430 // and would thus neither grow, nor be able to allocate an object.
431 const int kNumObjects = 100; 431 const int kNumObjects = 100;
432 const int kExpectedPages = (kNumObjects / (compaction_space->AreaSize() / 432 const int kExpectedPages = (kNumObjects / (compaction_space->AreaSize() /
433 Page::kMaxRegularHeapObjectSize)); 433 Page::kMaxRegularHeapObjectSize)) +
434 1;
434 for (int i = 0; i < kNumObjects; i++) { 435 for (int i = 0; i < kNumObjects; i++) {
435 compaction_space->AllocateRawUnaligned(Page::kMaxRegularHeapObjectSize) 436 compaction_space->AllocateRawUnaligned(Page::kMaxRegularHeapObjectSize)
436 .ToObjectChecked(); 437 .ToObjectChecked();
437 } 438 }
438 int pages_in_old_space = old_space->CountTotalPages(); 439 int pages_in_old_space = old_space->CountTotalPages();
439 int pages_in_compaction_space = compaction_space->CountTotalPages(); 440 int pages_in_compaction_space = compaction_space->CountTotalPages();
440 CHECK_EQ(pages_in_compaction_space, kExpectedPages); 441 CHECK_EQ(pages_in_compaction_space, kExpectedPages);
441 CHECK_LE(pages_in_old_space, 1); 442 CHECK_LE(pages_in_old_space, 1);
442 443
443 old_space->MergeCompactionSpace(compaction_space); 444 old_space->MergeCompactionSpace(compaction_space);
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
638 639
639 // Turn the allocation into a proper object so isolate teardown won't 640 // Turn the allocation into a proper object so isolate teardown won't
640 // crash. 641 // crash.
641 HeapObject* free_space = NULL; 642 HeapObject* free_space = NULL;
642 CHECK(allocation.To(&free_space)); 643 CHECK(allocation.To(&free_space));
643 new_space->heap()->CreateFillerObjectAt(free_space->address(), 80); 644 new_space->heap()->CreateFillerObjectAt(free_space->address(), 80);
644 } 645 }
645 } 646 }
646 isolate->Dispose(); 647 isolate->Dispose();
647 } 648 }
OLDNEW
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698