Issue 1401113004: Fix bad isolate summary charts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401113004: Fix bad isolate summary charts (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix bad isolate summary charts Charted charts persist some DOM children in the element and Polymer sends multiple attached() events, resulting in a stale chart svg element offsetting the current one. Fix is simple- remove stale elements in detached(). R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/53ebbc968b3626820f80c7d925b61fe8a1b06bdb

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	runtime/observatory/lib/src/elements/isolate_summary.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	runtime/observatory/lib/src/elements/isolate_summary.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 2 months ago (2015-10-12 19:53:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
53ebbc968b3626820f80c7d925b61fe8a1b06bdb (presubmit successful).