Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: runtime/observatory/lib/src/elements/isolate_summary.dart

Issue 1401113004: Fix bad isolate summary charts (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/isolate_summary.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/isolate_summary.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_summary.dart b/runtime/observatory/lib/src/elements/isolate_summary.dart
index 12ebe8146fff20cf47636f37b03ed756e476421e..b0b2e061b9985877f5518b1fd296c8219194e954 100644
--- a/runtime/observatory/lib/src/elements/isolate_summary.dart
+++ b/runtime/observatory/lib/src/elements/isolate_summary.dart
@@ -97,6 +97,15 @@ class IsolateCounterChartElement extends ObservatoryElement {
new CounterChart(shadowRoot.querySelector('#isolate-counter-chart'));
}
+ detached() {
+ super.detached();
+ var host = shadowRoot.querySelector('#isolate-counter-chart-host');
+ host.children.clear();
+ var legendHost =
+ shadowRoot.querySelector('#isolate-counter-chart-legend-host');
+ legendHost.children.clear();
+ }
+
void countersChanged(oldValue) {
if (counters == null) {
return;
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/isolate_summary.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698