Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1401073002: Add Rappor reporting for grant/deny/cancel/ignore of Mediastream permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call PermissionContextUmaUtil methods Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_uma_util.cc
diff --git a/chrome/browser/permissions/permission_context_uma_util.cc b/chrome/browser/permissions/permission_context_uma_util.cc
index 8ed9f8cac4958ca8933e35350334078a1d7210f6..c807256740dee2cad16ccf9650fc758678cd390c 100644
--- a/chrome/browser/permissions/permission_context_uma_util.cc
+++ b/chrome/browser/permissions/permission_context_uma_util.cc
@@ -71,6 +71,10 @@ const std::string GetRapporMetric(ContentSettingsType permission,
break;
}
+ if (permission == CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA ||
mlamouri (slow - plz ping) 2015/10/19 10:42:19 Could you explain?
tsergeant 2015/10/20 06:38:43 Added a comment.
+ permission == CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC)
+ return "";
+
std::string permission_str =
PermissionContextUmaUtil::GetPermissionString(permission);
if (permission_str.empty())
@@ -101,6 +105,22 @@ void RecordPermissionAction(ContentSettingsType permission,
"ContentSettings.PermissionActionsInsecureOrigin_Notifications",
action);
break;
+ case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
+ PERMISSION_ACTION_UMA(
+ secure_origin,
+ "ContentSettings.PermissionActions_MediaStreamCamera",
+ "ContentSettings.PermissionActionsSecureOrigin_MediaStreamCamera",
+ "ContentSettings.PermissionActionsInsecureOrigin_MediaStreamCamera",
mlamouri (slow - plz ping) 2015/10/19 10:42:19 Could you name these Permissions.Actions.VideoCapt
tsergeant 2015/10/20 06:38:43 Sure, sounds good. I can follow-up next week. I'v
mlamouri (slow - plz ping) 2015/10/20 11:00:40 Would it make sense to rename the current Permissi
tsergeant 2015/10/21 02:44:49 Done.
+ action);
+ break;
+ case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
+ PERMISSION_ACTION_UMA(
+ secure_origin,
+ "ContentSettings.PermissionActions_MediaStreamMic",
+ "ContentSettings.PermissionActionsSecureOrigin_MediaStreamMic",
+ "ContentSettings.PermissionActionsInsecureOrigin_MediaStreamMic",
mlamouri (slow - plz ping) 2015/10/19 10:42:19 Permissions.Actions.AudioCapture?
+ action);
+ break;
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
PERMISSION_ACTION_UMA(
secure_origin,

Powered by Google App Engine
This is Rietveld 408576698