Add Rappor reporting for grant/deny/cancel/ignore of Mediastream permissions

chrome/browser/permissions/permission_context_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_context_uma_util.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/permissions/permission_manager.h"
@@ skipping 53 matching lines @@
       action_str = "Dismissed";
       break;
     case IGNORED:
       action_str = "Ignored";
       break;
     default:
       NOTREACHED();
       break;
   }
 
+  if (permission == CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA ||

[mlamouri (slow - plz ping), 2015/10/19 10:42:19]

Could you explain?

[tsergeant, 2015/10/20 06:38:43]

Added a comment.

+      permission == CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC)
+    return "";
+
   std::string permission_str =
       PermissionContextUmaUtil::GetPermissionString(permission);
   if (permission_str.empty())
     return "";
   return base::StringPrintf("ContentSettings.PermissionActions_%s.%s.Url",
                             permission_str.c_str(), action_str.c_str());
 }
 
 void RecordPermissionAction(ContentSettingsType permission,
                             PermissionAction action,
@@ skipping 10 matching lines @@
             action);
         break;
       case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
         PERMISSION_ACTION_UMA(
             secure_origin,
             "ContentSettings.PermissionActions_Notifications",
             "ContentSettings.PermissionActionsSecureOrigin_Notifications",
             "ContentSettings.PermissionActionsInsecureOrigin_Notifications",
             action);
         break;
+      case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
+        PERMISSION_ACTION_UMA(
+            secure_origin,
+            "ContentSettings.PermissionActions_MediaStreamCamera",
+            "ContentSettings.PermissionActionsSecureOrigin_MediaStreamCamera",
+            "ContentSettings.PermissionActionsInsecureOrigin_MediaStreamCamera",

[mlamouri (slow - plz ping), 2015/10/19 10:42:19]

Could you name these Permissions.Actions.VideoCapture? I think we should move
these ContentSettings.* to Permissions.*. Maybe we could start with this one.
Would you be interested to do the follow-up?

[tsergeant, 2015/10/20 06:38:43]

Sure, sounds good. I can follow-up next week.

I've gone with "Permissions.Action_AudioCapture", aiming to match Rappor's
"Permissions.Action.AudioCapture", except that I can't change the existing
underscore separator.

[mlamouri (slow - plz ping), 2015/10/20 11:00:40]

Would it make sense to rename the current PermissionTypes suffix
ContentSettingsType and create a new PermissionTypes suffix that uses "." as a
separator? It seems that the suffixes names aren't really used, right?

[tsergeant, 2015/10/21 02:44:49]

Done.

+            action);
+        break;
+      case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
+        PERMISSION_ACTION_UMA(
+            secure_origin,
+            "ContentSettings.PermissionActions_MediaStreamMic",
+            "ContentSettings.PermissionActionsSecureOrigin_MediaStreamMic",
+            "ContentSettings.PermissionActionsInsecureOrigin_MediaStreamMic",

[mlamouri (slow - plz ping), 2015/10/19 10:42:19]

Permissions.Actions.AudioCapture?

+            action);
+        break;
       case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
         PERMISSION_ACTION_UMA(
             secure_origin,
             "ContentSettings.PermissionActions_MidiSysEx",
             "ContentSettings.PermissionActionsSecureOrigin_MidiSysEx",
             "ContentSettings.PermissionActionsInsecureOrigin_MidiSysEx",
             action);
         break;
       case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
         PERMISSION_ACTION_UMA(
@@ skipping 207 matching lines @@
       return "MidiSysEx";
     case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
       return "PushMessaging";
     case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
       return "DurableStorage";
 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
     case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
       return "ProtectedMediaIdentifier";
 #endif
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
       return "MediaStreamMic";

[mlamouri (slow - plz ping), 2015/10/19 10:42:19]

Please, rename to AudioCapture. There is a CL in progress to use PermissionType
in this method.

     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
       return "MediaStreamCamera";

[mlamouri (slow - plz ping), 2015/10/19 10:42:19]

ditto with VideoCapture.

     default:
       NOTREACHED();
       return "";
   }
 }