Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 140103003: xcode: Add xcassets = folder.assetcatalog to extension_map (Closed)

Created:
6 years, 11 months ago by matvore
Modified:
6 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

xcode: Add xcassets = folder.assetcatalog to extension_map This allows us to set the lastKnownFileType for files named, for instance, Images.xcassets. Committed r1843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pylib/gyp/xcodeproj_file.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
matvore
6 years, 11 months ago (2014-01-16 17:42:17 UTC) #1
Nico
xcode generator -> mark
6 years, 11 months ago (2014-01-22 21:04:36 UTC) #2
Mark Mentovai
LGTM
6 years, 11 months ago (2014-01-22 21:07:53 UTC) #3
matvore
Thank you for taking a look, Mark. I don't have committer rights, so would it ...
6 years, 11 months ago (2014-01-22 22:21:34 UTC) #4
Mark Mentovai
6 years, 11 months ago (2014-01-22 22:38:40 UTC) #5
Message was sent while issue was closed.
No problem. Committed r1843.

Powered by Google App Engine
This is Rietveld 408576698