Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 14009004: Remove methods on StackTrace class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/stacktrace_patch.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/core/stacktrace.dart » ('j') | tests/language/full_stacktrace2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index b77092feee794287364f37a3db0681ebc3ca23fa..3c1749a85e7ddca9245b6e53ec8cb9c814e9b0f6 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -822,13 +822,13 @@ unwrapException(ex) {
* exception.
*/
StackTrace getTraceFromException(exception) {
- return new StackTrace(JS("var", r"#.stack", exception));
+ return new _StackTrace(JS("var", r"#.stack", exception));
}
-class StackTrace {
- var stack;
- StackTrace(this.stack);
- String toString() => stack != null ? stack : '';
+class _StackTrace implements StackTrace {
+ var _stack;
+ _StackTrace(this._stack);
+ String toString() => _stack != null ? _stack : '';
}
« runtime/lib/stacktrace_patch.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/core/stacktrace.dart » ('j') | tests/language/full_stacktrace2_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698