Remove methods on StackTrace class.

tests/language/full_stacktrace2_test.dart

Index: tests/language/full_stacktrace2_test.dart
diff --git a/tests/language/full_stacktrace2_test.dart b/tests/language/full_stacktrace2_test.dart
index 7f45706adf45308d45de99752b69692634baf3af..840e9b7660e5a30069797af0f566e7dad7c69baa 100644
--- a/tests/language/full_stacktrace2_test.dart
+++ b/tests/language/full_stacktrace2_test.dart
@@ -4,8 +4,11 @@
 
 import "package:expect/expect.dart";
 
+// This test assumes that all called functions occur in the stack trace.
+// This might not be the case if inlining methods.

[Ivan Posva, 2013/04/12 03:13:10]

This is a current limitation of dart2js and not something that we should spell
out in the language tests as it sounds like it is part of the expectation.
We had been documenting this either in the status file or in a bug linked from
the status file.

[Lasse Reichstein Nielsen, 2013/04/15 11:37:22]

I'll remove this for now, and keep it in the status files. The dart2js people
can the say whether they expect this to change in the future or not.

+
 void func1() {
-  throw new Exception("Test peanut gallery request for Full stacktrace");
+  throw new Exception("Test full stacktrace");
 }
 void func2() {
   func1();
@@ -14,36 +17,15 @@ void func3() {
   try {
     func2();
   } on Object catch(e, s) {
-    print(e);
-
-    var full_trace = s.fullStackTrace;
-    Expect.isTrue(full_trace.contains("func1"));
-    Expect.isTrue(full_trace.contains("func2"));
-    Expect.isTrue(full_trace.contains("func3"));
-    Expect.isTrue(full_trace.contains("func4"));
-    Expect.isTrue(full_trace.contains("func5"));
-    Expect.isTrue(full_trace.contains("func6"));
-    Expect.isTrue(full_trace.contains("func7"));
-    Expect.isTrue(full_trace.contains("main"));
-
-    var trace = s.stackTrace;
-    Expect.isTrue(trace.contains("func1"));
-    Expect.isTrue(trace.contains("func2"));
-    Expect.isTrue(trace.contains("func3"));
-
-    Expect.isFalse(trace.contains("func4"));
-    Expect.isFalse(trace.contains("func5"));
-    Expect.isFalse(trace.contains("func6"));
-    Expect.isFalse(trace.contains("func7"));
-    Expect.isFalse(trace.contains("main"));
-
-    print(s);
-
-    print("Full stack trace");
-    print(full_trace);
-
-    print("Stack trace");
-    print(trace);
+    var fullTrace = s.toString();
+    Expect.isTrue(fullTrace.contains("func1"));
+    Expect.isTrue(fullTrace.contains("func2"));
+    Expect.isTrue(fullTrace.contains("func3"));
+    Expect.isTrue(fullTrace.contains("func4"));
+    Expect.isTrue(fullTrace.contains("func5"));
+    Expect.isTrue(fullTrace.contains("func6"));
+    Expect.isTrue(fullTrace.contains("func7"));
+    Expect.isTrue(fullTrace.contains("main"));
 
     throw;  // This is a rethrow.
   }
@@ -56,36 +38,15 @@ int func5() {
   try {
     func4();
   } on Object catch(e, s) {
-
-    var full_trace = s.fullStackTrace;
-    print(full_trace);
-    Expect.isTrue(full_trace.contains("func1"));
-    Expect.isTrue(full_trace.contains("func2"));
-    Expect.isTrue(full_trace.contains("func3"));
-    Expect.isTrue(full_trace.contains("func4"));
-    Expect.isTrue(full_trace.contains("func5"));
-    Expect.isTrue(full_trace.contains("func6"));
-    Expect.isTrue(full_trace.contains("func7"));
-    Expect.isTrue(full_trace.contains("main"));
-
-    var trace = s.stackTrace;
-    Expect.isTrue(trace.contains("func1"));
-    Expect.isTrue(trace.contains("func2"));
-    Expect.isTrue(trace.contains("func3"));
-    Expect.isTrue(trace.contains("func4"));
-    Expect.isTrue(trace.contains("func5"));
-
-    Expect.isFalse(trace.contains("func6"));
-    Expect.isFalse(trace.contains("func7"));
-    Expect.isFalse(trace.contains("main"));
-
-    print(s);
-
-    print("Full stack trace");
-    print(full_trace);
-
-    print("Stack trace");
-    print(trace);
+    var fullTrace = s.toString();
+    Expect.isTrue(fullTrace.contains("func1"));
+    Expect.isTrue(fullTrace.contains("func2"));
+    Expect.isTrue(fullTrace.contains("func3"));
+    Expect.isTrue(fullTrace.contains("func4"));
+    Expect.isTrue(fullTrace.contains("func5"));
+    Expect.isTrue(fullTrace.contains("func6"));
+    Expect.isTrue(fullTrace.contains("func7"));
+    Expect.isTrue(fullTrace.contains("main"));
   }
   return 1;
 }