Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tests/language/full_stacktrace2_test.dart

Issue 14009004: Remove methods on StackTrace class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/full_stacktrace2_test.dart
diff --git a/tests/language/full_stacktrace2_test.dart b/tests/language/full_stacktrace2_test.dart
index 7f45706adf45308d45de99752b69692634baf3af..2b63983947512dd4a5946a0d8ff8621e089c67e8 100644
--- a/tests/language/full_stacktrace2_test.dart
+++ b/tests/language/full_stacktrace2_test.dart
@@ -4,8 +4,11 @@
import "package:expect/expect.dart";
+// This test assumes that all called functions occur in the stack trace.
+// This might not be the case if inlining methods.
+
void func1() {
- throw new Exception("Test peanut gallery request for Full stacktrace");
+ throw new Exception("Test full stacktrace");
}
void func2() {
func1();
@@ -14,9 +17,7 @@ void func3() {
try {
func2();
} on Object catch(e, s) {
- print(e);
-
- var full_trace = s.fullStackTrace;
+ var full_trace = s.toString();
kasperl 2013/04/11 09:29:48 full_trace -> fullTrace
Expect.isTrue(full_trace.contains("func1"));
Expect.isTrue(full_trace.contains("func2"));
Expect.isTrue(full_trace.contains("func3"));
@@ -26,25 +27,6 @@ void func3() {
Expect.isTrue(full_trace.contains("func7"));
Expect.isTrue(full_trace.contains("main"));
- var trace = s.stackTrace;
- Expect.isTrue(trace.contains("func1"));
- Expect.isTrue(trace.contains("func2"));
- Expect.isTrue(trace.contains("func3"));
-
- Expect.isFalse(trace.contains("func4"));
- Expect.isFalse(trace.contains("func5"));
- Expect.isFalse(trace.contains("func6"));
- Expect.isFalse(trace.contains("func7"));
- Expect.isFalse(trace.contains("main"));
-
- print(s);
-
- print("Full stack trace");
- print(full_trace);
-
- print("Stack trace");
- print(trace);
-
throw; // This is a rethrow.
}
}
@@ -57,8 +39,7 @@ int func5() {
func4();
} on Object catch(e, s) {
- var full_trace = s.fullStackTrace;
- print(full_trace);
+ var full_trace = s.toString();
kasperl 2013/04/11 09:29:48 Ditto.
Expect.isTrue(full_trace.contains("func1"));
Expect.isTrue(full_trace.contains("func2"));
Expect.isTrue(full_trace.contains("func3"));
@@ -67,25 +48,6 @@ int func5() {
Expect.isTrue(full_trace.contains("func6"));
Expect.isTrue(full_trace.contains("func7"));
Expect.isTrue(full_trace.contains("main"));
-
- var trace = s.stackTrace;
- Expect.isTrue(trace.contains("func1"));
- Expect.isTrue(trace.contains("func2"));
- Expect.isTrue(trace.contains("func3"));
- Expect.isTrue(trace.contains("func4"));
- Expect.isTrue(trace.contains("func5"));
-
- Expect.isFalse(trace.contains("func6"));
- Expect.isFalse(trace.contains("func7"));
- Expect.isFalse(trace.contains("main"));
-
- print(s);
-
- print("Full stack trace");
- print(full_trace);
-
- print("Stack trace");
- print(trace);
}
return 1;
}

Powered by Google App Engine
This is Rietveld 408576698