tests/language/full_stacktrace3_test.dart - Issue 14009004: Remove methods on StackTrace class.

Unified Diff: tests/language/full_stacktrace3_test.dart

Issue 14009004: Remove methods on StackTrace class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/language/full_stacktrace2_test.dart ('K') | « tests/language/full_stacktrace2_test.dart ('k') | tests/language/language_dart2js.status » ('j') | tests/language/language_dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/language/full_stacktrace3_test.dart

diff --git a/tests/language/full_stacktrace3_test.dart b/tests/language/full_stacktrace3_test.dart

index 4bacd04624266e4e6d75bf85c76eb0be6a464276..227537dc20cb4745060da5cb4186edbb3f30e85d 100644

--- a/tests/language/full_stacktrace3_test.dart

+++ b/tests/language/full_stacktrace3_test.dart

@@ -4,8 +4,11 @@

import "package:expect/expect.dart";

+// This test assumes that all called functions occur in the stack trace.

+// This might not be the case if inlining methods.

void func1() {

- throw new Exception("Test peanut gallery request for Full stacktrace");

+ throw new Exception("Test full stacktrace");

}

void func2() {

func1();

@@ -14,8 +17,7 @@ void func3() {

try {

func2();

} on Object catch(e, s) {

- print(e);

- var full_trace = s.fullStackTrace;

+ var full_trace = s.toString();

kasperl 2013/04/11 09:29:48 fullTrace

Expect.isTrue(full_trace.contains("func1"));

Expect.isTrue(full_trace.contains("func2"));

Expect.isTrue(full_trace.contains("func3"));

@@ -24,25 +26,6 @@ void func3() {

Expect.isTrue(full_trace.contains("func6"));

Expect.isTrue(full_trace.contains("func7"));

Expect.isTrue(full_trace.contains("main"));

- var trace = s.stackTrace;

- Expect.isTrue(trace.contains("func1"));

- Expect.isTrue(trace.contains("func2"));

- Expect.isTrue(trace.contains("func3"));

- Expect.isFalse(trace.contains("func4"));

- Expect.isFalse(trace.contains("func5"));

- Expect.isFalse(trace.contains("func6"));

- Expect.isFalse(trace.contains("func7"));

- Expect.isFalse(trace.contains("main"));

- print(s);

- print("Full stack trace");

- print(full_trace);

- print("Stack trace");

- print(trace);

throw new Exception("This is not a rethrow");

}

@@ -54,7 +37,7 @@ int func5() {

try {

func4();

} on Object catch(e, s) {

- var full_trace = s.fullStackTrace;

+ var full_trace = s.toString();

kasperl 2013/04/11 09:29:48 Ditto.

Expect.isFalse(full_trace.contains("func1"));

Expect.isFalse(full_trace.contains("func2"));