Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h

Issue 1400823003: Creates BrowserTabStripTracker to consolidate common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback and git cl format Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h
diff --git a/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h b/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h
index 81236e99012d8acffd8ba4f8ab3453fd0feb8c6e..a93762637ea14f0bfc732d7c96ac21e886fa54a3 100644
--- a/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h
+++ b/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h
@@ -6,7 +6,7 @@
#define CHROME_BROWSER_UI_ASH_METRICS_CHROME_USER_METRICS_RECORDER_H_
#include "base/macros.h"
-#include "chrome/browser/ui/browser_list_observer.h"
+#include "chrome/browser/ui/browser_tab_strip_tracker.h"
#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
namespace content {
@@ -14,16 +14,11 @@ class WebContents;
} // namespace content
// A bridge proxy between chrome/browser events and ash::UserMetricsRecorder.
-class ChromeUserMetricsRecorder : public chrome::BrowserListObserver,
- public TabStripModelObserver {
+class ChromeUserMetricsRecorder : public TabStripModelObserver {
public:
ChromeUserMetricsRecorder();
~ChromeUserMetricsRecorder() override;
- // chrome::BroswerListObserver:
- void OnBrowserAdded(Browser* browser) override;
- void OnBrowserRemoved(Browser* browser) override;
-
// TabStripModelObserver:
void ActiveTabChanged(content::WebContents* old_contents,
content::WebContents* new_contents,
@@ -34,6 +29,8 @@ class ChromeUserMetricsRecorder : public chrome::BrowserListObserver,
// Called when a different tab becomes active due to a user gesture.
void OnTabSwitchedByUserGesture();
+ BrowserTabStripTracker browser_tab_strip_tracker_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeUserMetricsRecorder);
};

Powered by Google App Engine
This is Rietveld 408576698