Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6358)

Unified Diff: chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc

Issue 1400823003: Creates BrowserTabStripTracker to consolidate common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback and git cl format Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc
diff --git a/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc b/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc
index bed0f5e9ef2f822002c5aa88e8d310b73c635718..726720adc5abd15bba92d417d252949c0a7c33cf 100644
--- a/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc
+++ b/chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc
@@ -8,26 +8,18 @@
#include "ash/metrics/user_metrics_recorder.h"
#include "ash/shell.h"
#include "base/logging.h"
-#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-ChromeUserMetricsRecorder::ChromeUserMetricsRecorder() {
- BrowserList::AddObserver(this);
+ChromeUserMetricsRecorder::ChromeUserMetricsRecorder()
+ : browser_tab_strip_tracker_(this, nullptr, nullptr) {
+ browser_tab_strip_tracker_.Init(
+ BrowserTabStripTracker::InitWith::ALL_BROWERS);
}
ChromeUserMetricsRecorder::~ChromeUserMetricsRecorder() {
DCHECK(BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH)->empty());
- BrowserList::RemoveObserver(this);
-}
-
-void ChromeUserMetricsRecorder::OnBrowserAdded(Browser* browser) {
- browser->tab_strip_model()->AddObserver(this);
-}
-
-void ChromeUserMetricsRecorder::OnBrowserRemoved(Browser* browser) {
- browser->tab_strip_model()->RemoveObserver(this);
}
void ChromeUserMetricsRecorder::ActiveTabChanged(
« no previous file with comments | « chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h ('k') | chrome/browser/ui/browser_tab_strip_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698