Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1400813008: Fix closure compile after Polymer update (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@roll-polymer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compile after Polymer update Currently in review: https://github.com/PolymerLabs/polymer-externs/pull/32 Landed but not yet updated in bower: https://github.com/PolymerElements/paper-behaviors/pull/35 R=dzhioev@chromium.org TBR=fukino@chromium.org BUG=none Committed: https://crrev.com/62aed60245094d3e9ecdfb7e8543cefd2ffdd96e Cr-Commit-Position: refs/heads/master@{#353660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M third_party/polymer/v1_0/chromium.patch View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1401633002 Patch 40001

Messages

Total messages: 13 (4 generated)
Dan Beam
5 years, 2 months ago (2015-10-13 00:32:51 UTC) #1
Dan Beam
this is the break: http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/36332
5 years, 2 months ago (2015-10-13 00:33:04 UTC) #2
dzhioev (left Google)
On 2015/10/13 00:33:04, Dan Beam wrote: > this is the break: > http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/36332 LGTM
5 years, 2 months ago (2015-10-13 00:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400813008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400813008/1
5 years, 2 months ago (2015-10-13 00:49:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/108763)
5 years, 2 months ago (2015-10-13 00:59:48 UTC) #7
Dan Beam
TBR=fukino@ for ui/file_manager compiled_resources.gyp addition
5 years, 2 months ago (2015-10-13 01:00:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400813008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400813008/1
5 years, 2 months ago (2015-10-13 01:02:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 01:54:35 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 01:55:18 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/62aed60245094d3e9ecdfb7e8543cefd2ffdd96e
Cr-Commit-Position: refs/heads/master@{#353660}

Powered by Google App Engine
This is Rietveld 408576698