Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js

Issue 1400813008: Fix closure compile after Polymer update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@roll-polymer
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js b/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js
index 12df07809623998eca865fa25149d5e13346188d..00ab72b417950d60cd34c85288b5d1b996bbdd3c 100644
--- a/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/paper-behaviors/paper-ripple-behavior-extracted.js
@@ -44,10 +44,10 @@
/**
* Ensures this element contains a ripple effect. For startup efficiency
* the ripple effect is dynamically on demand when needed.
- * @param {event} triggeringEvent (optional) event that triggered the
+ * @param {!Event=} opt_triggeringEvent (optional) event that triggered the
* ripple.
*/
- ensureRipple: function(triggeringEvent) {
+ ensureRipple: function(opt_triggeringEvent) {
if (!this.hasRipple()) {
this._ripple = this._createRipple();
this._ripple.noink = this.noink;
@@ -57,8 +57,9 @@
}
var domContainer = rippleContainer === this.shadyRoot ? this :
rippleContainer;
- if (triggeringEvent && domContainer.contains(triggeringEvent.target)) {
- this._ripple.uiDownAction(triggeringEvent);
+ if (opt_triggeringEvent &&
+ domContainer.contains(opt_triggeringEvent.target)) {
+ this._ripple.uiDownAction(opt_triggeringEvent);
}
}
},
@@ -97,4 +98,4 @@
}
}
- };
+ };

Powered by Google App Engine
This is Rietveld 408576698