Issue 1400663003: Merge to XFA: Fix a malloc/delete mismatch introduced in commit 8a9ce57.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1400663003: Merge to XFA: Fix a malloc/delete mismatch introduced in commit 8a9ce57. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix a malloc/delete mismatch introduced in commit 8a9ce57. Just get rid of the malloc altogether and use CJBig2_List instead. BUG=540873 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1394933002 . (cherry picked from commit 06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1) Committed: https://pdfium.googlesource.com/pdfium/+/a51027d660e30da1ceaa7a025257725341649ffb

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -31 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_GsidProc.cpp	View		2 chunks	+17 lines, -31 lines	0 comments	Download
	M	core/src/fxcodec/jbig2/JBig2_List.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-08 22:55:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a51027d660e30da1ceaa7a025257725341649ffb (presubmit successful).