Fix a malloc/delete mismatch introduced in commit 8a9ce57.

Fix a malloc/delete mismatch introduced in commit 8a9ce57.

Just get rid of the malloc altogether and use CJBig2_List instead.

BUG=540873
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1

[Lei Zhang, 2015-10-08 19:28:57]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-10-08 19:57:34]

lgtm

https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_GsidProc.cpp (right):

https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_GsidProc.cpp:43: CJBig2_Image* pImage = nullptr;
nit: maybe fold this into the for loop below, the only differnce seems to be the
xor on the first pass, which is easily checked via index value.

[Tom Sepez, 2015-10-08 19:58:02]

On 2015/10/08 19:57:34, Tom Sepez wrote:
> lgtm
> 
>
https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
> File core/src/fxcodec/jbig2/JBig2_GsidProc.cpp (right):
> 
>
https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
> core/src/fxcodec/jbig2/JBig2_GsidProc.cpp:43: CJBig2_Image* pImage = nullptr;
> nit: maybe fold this into the for loop below, the only differnce seems to be
the
> xor on the first pass, which is easily checked via index value.
xor *not* on the first pass.

[Lei Zhang, 2015-10-08 22:14:19]

https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_GsidProc.cpp (right):

https://codereview.chromium.org/1394933002/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_GsidProc.cpp:43: CJBig2_Image* pImage = nullptr;
On 2015/10/08 19:57:34, Tom Sepez wrote:
> nit: maybe fold this into the for loop below, the only differnce seems to be
the
> xor on the first pass, which is easily checked via index value.

Done.

[Lei Zhang, 2015-10-08 22:27:32]

Committed patchset #3 (id:40001) manually as
06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1 (presubmit successful).