Issue 1400503003: Merge to XFA: Only call DefineJSObjects() once for the global V8 isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1400503003: Merge to XFA: Only call DefineJSObjects() once for the global V8 isolate. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Only call DefineJSObjects() once for the global V8 isolate. BUG=539106 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1386823002 . (cherry picked from commit 7dfe5929282cb6d78d7b5e32e1d72e9db99d3066) Committed: https://pdfium.googlesource.com/pdfium/+/3fa115bf1d6b86fcdbc9a139c6ac789ea2294c2e

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, trivial manual merge in fpdfsdk/src/javascript/JS_Runtime.cpp.

5 years, 2 months ago (2015-10-08 19:03:25 UTC) #1

Lei Zhang

5 years, 2 months ago (2015-10-08 19:04:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3fa115bf1d6b86fcdbc9a139c6ac789ea2294c2e (presubmit successful).