Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1400353002: [Interpreter]: Use vector store for array literal computed stores. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Use vector store for array literal computed stores. Replaces the use of KeyedStoreICGeneric with a vector based KeyedStoreIC for array literal computed stores now that there is a feedback vector slot for these expressions. Removes KeyedStoreICGeneric bytecode since this is no longer necessary. BUG=v8:4280 LOG=N TBR=mstarzinger@chromium.org Committed: https://crrev.com/2ad5655260c04f7cb1dbae974a95645e0b22a82c Cr-Commit-Position: refs/heads/master@{#31262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -93 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 3 chunks +62 lines, -53 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
rmcilroy
Michael: This CL replaces the generic keyed store on array literals with the vector store ...
5 years, 2 months ago (2015-10-14 11:00:23 UTC) #2
mvstanton
lgtm, very nice!
5 years, 2 months ago (2015-10-14 11:05:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400353002/1
5 years, 2 months ago (2015-10-14 11:27:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 11:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400353002/1
5 years, 2 months ago (2015-10-14 12:01:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6625)
5 years, 2 months ago (2015-10-14 12:22:43 UTC) #11
rmcilroy
TBRing Michi for minor change in compiler/bytecode-graph-builder.cc to remove the Generic KeyedStoreIC bytecode.
5 years, 2 months ago (2015-10-14 13:17:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400353002/1
5 years, 2 months ago (2015-10-14 13:18:10 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 13:19:53 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 13:20:25 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ad5655260c04f7cb1dbae974a95645e0b22a82c
Cr-Commit-Position: refs/heads/master@{#31262}

Powered by Google App Engine
This is Rietveld 408576698