Issue 140034: Define the == operator for X509Certificate::Fingerprint....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140034: Define the == operator for X509Certificate::Fingerprint.... (Closed)

Created:
11 years, 6 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Define the == operator for X509Certificate::Fingerprint. R=eroman BUG=http://crbug.com/318 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19029

Patch Set 1 #

Patch Set 2 : Upload before checkin #

Total comments: 1

Patch Set 3 : List operator== after data member #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	net/base/x509_certificate.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	net/http/http_network_transaction.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 6 months ago (2009-06-23 02:20:14 UTC) #3

http://codereview.chromium.org/140034/diff/2001/2003
File net/base/x509_certificate.h (right):

http://codereview.chromium.org/140034/diff/2001/2003#newcode43
Line 43: bool operator==(const Fingerprint& other) const {
Eric, are we supposed to move this operator before the
data member?  Since this is a 'struct', it's not clear to
me if the "methods before data members" guideline in the
style guide applies...

Expand Messages | Collapse Messages