Chromium Code Reviews
Help | Chromium Project | Sign in
(466)

Issue 140034: Define the == operator for X509Certificate::Fingerprint.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by wtc
Modified:
4 years, 2 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Define the == operator for X509Certificate::Fingerprint. R=eroman BUG=http://crbug.com/318 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19029

Patch Set 1 #

Patch Set 2 : Upload before checkin #

Total comments: 1

Patch Set 3 : List operator== after data member #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M net/base/x509_certificate.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
wtc
6 years, 1 month ago (2009-06-20 00:38:01 UTC) #1
eroman
lgtm
6 years, 1 month ago (2009-06-20 01:12:33 UTC) #2
wtc
6 years, 1 month ago (2009-06-23 02:20:14 UTC) #3
http://codereview.chromium.org/140034/diff/2001/2003
File net/base/x509_certificate.h (right):

http://codereview.chromium.org/140034/diff/2001/2003#newcode43
Line 43: bool operator==(const Fingerprint& other) const {
Eric, are we supposed to move this operator before the
data member?  Since this is a 'struct', it's not clear to
me if the "methods before data members" guideline in the
style guide applies...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5