Aura on Android: Making it possible to generate GN build configuration

Aura on Android: Making it possible to generate GN build configuration

Making it so that we can pass the "gn args" step with android/use_aura/toolkit_views.

BUG=507792
Committed: https://crrev.com/e7766a065da54d7eb3fad5431e997e367b11c76c
Cr-Commit-Position: refs/heads/master@{#354043}

[mfomitchev, 2015-10-13 18:48:20]

mfomitchev@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-10-13 20:04:41]

LGTM

[no sievers, 2015-10-13 20:47:47]

sievers@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2015-10-13 20:47:47]

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:16:
'browser/ui/android/autofill/autofill_dialog_controller_android.cc',
why the changes in here though? or rather, why did you leave some android files
under 'chrome_browser_ui_non_ios_sources'?

[mfomitchev, 2015-10-13 21:27:11]

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:16:
'browser/ui/android/autofill/autofill_dialog_controller_android.cc',
On 2015/10/13 20:47:47, sievers wrote:
> why the changes in here though? or rather, why did you leave some android
files
> under 'chrome_browser_ui_non_ios_sources'?

This is basically what we did in https://codereview.chromium.org/1391893003/,
except that instead of removing the files explicitly in
chrome/browser/ui/BUILD.gn, I've moved them from
chrome_browser_ui_non_ios_sources to chrome_browser_ui_android_sources.

We could probably remove more (if not all of them). I suggest we log a bug to
make sure we remember. Alternatively, we can do it now, but that would mean we'd
need to do more work before we can have it running.

[no sievers, 2015-10-13 21:52:05]

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:422: 'chrome_browser_ui_android_sources': [
mind renaming this to 'chrome_browser_ui_android_non_aura_sources' then?

[mfomitchev, 2015-10-14 16:02:30]

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:422: 'chrome_browser_ui_android_sources': [
On 2015/10/13 21:52:05, sievers wrote:
> mind renaming this to 'chrome_browser_ui_android_non_aura_sources' then?

Done.

[no sievers, 2015-10-14 16:08:21]

On 2015/10/14 16:02:30, mfomitchev wrote:
>
https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gypi
> File chrome/chrome_browser_ui.gypi (right):
> 
>
https://codereview.chromium.org/1400243002/diff/1/chrome/chrome_browser_ui.gy...
> chrome/chrome_browser_ui.gypi:422: 'chrome_browser_ui_android_sources': [
> On 2015/10/13 21:52:05, sievers wrote:
> > mind renaming this to 'chrome_browser_ui_android_non_aura_sources' then?
> 
> Done.

thanks lgtm too!

[mfomitchev, 2015-10-14 16:38:00]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2015-10-14 16:38:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1400243002/#ps20001
(title: "Renaming chrome_browser_ui_android_sources to
chrome_browser_ui_android_non_aura_sources.")

[commit-bot: I haz the power, 2015-10-14 16:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1400243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1400243002/20001

[commit-bot: I haz the power, 2015-10-14 16:56:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-14 16:57:43]

Patchset 2 (id:??) landed as
https://crrev.com/e7766a065da54d7eb3fad5431e997e367b11c76c
Cr-Commit-Position: refs/heads/master@{#354043}