Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394783005: Aura on Android: Idle monitor stub implementation (Closed)

Created:
5 years, 2 months ago by mfomitchev
Modified:
5 years, 2 months ago
Reviewers:
sadrul, no sievers
CC:
chromium-reviews, bshe
Base URL:
https://chromium.googlesource.com/chromium/src.git@auraclank_upstream
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura on Android: Idle monitor stub implementation BUG=507792 Committed: https://crrev.com/95ed56d2397ecdcd5fef61c6616626a1cb8493e3 Cr-Commit-Position: refs/heads/master@{#354345}

Patch Set 1 #

Patch Set 2 : Forgot a comma in ui_base.gyp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M ui/base/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
A + ui/base/idle/idle_android.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M ui/base/ui_base.gyp View 1 3 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1400243002 Patch 20001

Dependent Patchsets:

Issue 1405773004 Patch 1
Issue 1405773004 Patch 20001
Issue 1405773004 Patch 40001
Issue 1405773004 Patch 60001

Messages

Total messages: 9 (3 generated)
mfomitchev
5 years, 2 months ago (2015-10-14 16:43:55 UTC) #2
no sievers
lgtm
5 years, 2 months ago (2015-10-14 16:52:10 UTC) #3
sadrul
lgtm
5 years, 2 months ago (2015-10-15 19:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394783005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394783005/20001
5 years, 2 months ago (2015-10-15 19:57:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 20:40:30 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 20:41:54 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/95ed56d2397ecdcd5fef61c6616626a1cb8493e3
Cr-Commit-Position: refs/heads/master@{#354345}

Powered by Google App Engine
This is Rietveld 408576698