[WIP] Yet another demo for BMM NaCl ppapi connection.

ipc/ipc_channel_posix.cc

Index: ipc/ipc_channel_posix.cc
diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc
index 878853290016620a1276ce2707ed52b8a7fa7f9b..b5324460c1112b365643b962ecc4bc452435aea8 100644
--- a/ipc/ipc_channel_posix.cc
+++ b/ipc/ipc_channel_posix.cc
@@ -195,7 +195,7 @@ Channel::ChannelImpl::~ChannelImpl() {
   Close();
 }
 
-bool SocketPair(int* fd1, int* fd2) {
+bool Channel::ChannelImpl::SocketPair(int* fd1, int* fd2) {
   int pipe_fds[2];
   if (socketpair(AF_UNIX, SOCK_STREAM, 0, pipe_fds) != 0) {
     PLOG(ERROR) << "socketpair()";
@@ -1105,6 +1105,11 @@ std::string Channel::GenerateVerifiedChannelID(const std::string& prefix) {
 void Channel::SetGlobalPid(int pid) {
   ChannelImpl::SetGlobalPid(pid);
 }
+
+// static
+bool Channel::SocketPair(int* fd1, int* fd2) {

[Mark Seaborn, 2014/02/03 22:59:07]

Why have a layer of wrapping?

You could just declare SocketPair() as a function inside the IPC namespace.  It
doesn't need to be a static member of a class.

However, this part isn't needed for the first (refactoring-only) commit...

+  return Channel::ChannelImpl::SocketPair(fd1, fd2);
+}
 #endif  // OS_LINUX
 
 }  // namespace IPC