[WIP] Yet another demo for BMM NaCl ppapi connection.

ipc/ipc_channel_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_channel_posix.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/socket.h>
@@ skipping 177 matching lines @@
     const char *modestr = (mode_ & MODE_SERVER_FLAG) ? "server" : "client";
     LOG(WARNING) << "Unable to create pipe named \"" << channel_handle.name
                  << "\" in " << modestr << " mode";
   }
 }
 
 Channel::ChannelImpl::~ChannelImpl() {
   Close();
 }
 
-bool SocketPair(int* fd1, int* fd2) {
+bool Channel::ChannelImpl::SocketPair(int* fd1, int* fd2) {
   int pipe_fds[2];
   if (socketpair(AF_UNIX, SOCK_STREAM, 0, pipe_fds) != 0) {
     PLOG(ERROR) << "socketpair()";
     return false;
   }
 
   // Set both ends to be non-blocking.
   if (fcntl(pipe_fds[0], F_SETFL, O_NONBLOCK) == -1 ||
       fcntl(pipe_fds[1], F_SETFL, O_NONBLOCK) == -1) {
     PLOG(ERROR) << "fcntl(O_NONBLOCK)";
@@ skipping 889 matching lines @@
 
   return id.append(GenerateUniqueRandomChannelID());
 }
 
 
 #if defined(OS_LINUX)
 // static
 void Channel::SetGlobalPid(int pid) {
   ChannelImpl::SetGlobalPid(pid);
 }
+
+// static
+bool Channel::SocketPair(int* fd1, int* fd2) {

[Mark Seaborn, 2014/02/03 22:59:07]

Why have a layer of wrapping?

You could just declare SocketPair() as a function inside the IPC namespace.  It
doesn't need to be a static member of a class.

However, this part isn't needed for the first (refactoring-only) commit...

+  return Channel::ChannelImpl::SocketPair(fd1, fd2);
+}
 #endif  // OS_LINUX
 
 }  // namespace IPC