components/favicon/ios/web_favicon_driver.h - Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/ios/web_favicon_driver.h

Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_remove_validity_check

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/favicon/content/content_favicon_driver.h ('K') | « components/favicon/core/favicon_handler_unittest.cc ('k') | components/favicon/ios/web_favicon_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon/ios/web_favicon_driver.h

diff --git a/components/favicon/ios/web_favicon_driver.h b/components/favicon/ios/web_favicon_driver.h

index 0be7bcef3a2e24ac91fa6c2abb6ec9648c02fed3..1e17e49e4c3985dbebcffc8e483e874e6840c33d 100644

--- a/components/favicon/ios/web_favicon_driver.h

+++ b/components/favicon/ios/web_favicon_driver.h

@@ -35,7 +35,6 @@ class WebFaviconDriver : public web::WebStateObserver,

int StartDownload(const GURL& url, int max_bitmap_size) override;

bool IsOffTheRecord() override;

GURL GetActiveURL() override;

- bool GetActiveFaviconValidity() override;

void SetActiveFaviconValidity(bool valid) override;

GURL GetActiveFaviconURL() override;

void SetActiveFaviconURL(const GURL& url) override;

@@ -50,9 +49,6 @@ class WebFaviconDriver : public web::WebStateObserver,

bookmarks::BookmarkModel* bookmark_model);

~WebFaviconDriver() override;

- // Returns whether the active URL has changed since FetchFavicon() was called.

- bool ActiveURLChangedSinceFetchFavicon();

// web::WebStateObserver implementation.

void FaviconUrlUpdated(

const std::vector<web::FaviconURL>& candidates) override;