components/favicon/content/content_favicon_driver.h - Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_remove_validity_check

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/content/content_favicon_driver.h

diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h

index adbc7e79866efc738ba1297f88b847dbf47bf406..1af8bb17115d77cbcfa4c4f218de463988868986 100644

--- a/components/favicon/content/content_favicon_driver.h

+++ b/components/favicon/content/content_favicon_driver.h

@@ -47,7 +47,6 @@ class ContentFaviconDriver

int StartDownload(const GURL& url, int max_bitmap_size) override;

bool IsOffTheRecord() override;

GURL GetActiveURL() override;

- bool GetActiveFaviconValidity() override;

void SetActiveFaviconValidity(bool valid) override;

sky 2015/10/12 16:05:32 Can you get rid of the setter too? Otherwise this

pkotwicz 2015/10/13 14:46:37 I can't remove the setter yet because it is called

GURL GetActiveFaviconURL() override;

void SetActiveFaviconURL(const GURL& url) override;

« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.cc » ('j') | no next file with comments »