Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/typing.cc

Issue 1399893002: [es7] implement |do| expressions proposal (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Some cleanup Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 2cd75e7eb69b14a73698087c0787295b229fcdc8..9152f81e82b2b78b0c7e3b1bdf7cd62dac06067b 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -348,6 +348,12 @@ void AstTyper::VisitNativeFunctionLiteral(NativeFunctionLiteral* expr) {
}
+void AstTyper::VisitDoExpression(DoExpression* expr) {
+ RECURSE(VisitBlock(expr->block()));
+ RECURSE(VisitVariableProxy(expr->result()));
rossberg 2015/10/13 10:44:33 This function should set the type of the do-node t
caitp (gmail) 2015/10/13 15:06:00 Done, I think.. It's not clear that the Proxy's bo
rossberg 2015/10/15 09:58:27 True, but that is generally true when you try to t
+}
+
+
void AstTyper::VisitConditional(Conditional* expr) {
// Collect type feedback.
expr->condition()->RecordToBooleanTypeFeedback(oracle());

Powered by Google App Engine
This is Rietveld 408576698