src/typing-asm.cc - Issue 1399893002: [es7] implement |do| expressions proposal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing-asm.cc

Issue 1399893002: [es7] implement |do| expressions proposal (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Some cleanup Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing-asm.cc

diff --git a/src/typing-asm.cc b/src/typing-asm.cc

index 501af026dcba8b636aed0c653a9eae3a2efc7cd9..59b778e45696d9baa85c4a482b0c12a4040a0ac0 100644

--- a/src/typing-asm.cc

+++ b/src/typing-asm.cc

@@ -435,6 +435,12 @@ void AsmTyper::VisitNativeFunctionLiteral(NativeFunctionLiteral* expr) {

}

+void AsmTyper::VisitDoExpression(DoExpression* expr) {

rossberg 2015/10/13 10:44:33 This function needs to fail, do-expressions are no

caitp (gmail) 2015/10/13 15:06:00 Done

+ RECURSE(VisitBlock(expr->block()));

+ RECURSE(VisitVariableProxy(expr->result()));

void AsmTyper::VisitConditional(Conditional* expr) {

RECURSE(VisitWithExpectation(expr->condition(), cache_.kInt32,

"condition expected to be integer"));