Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParser.cpp

Issue 1399853005: Changed CSSColorValue to return a Color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_color
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
index 9fc5d92d6c4668a658bd1c75510bb985145649c5..4e84fa1a883d67b3d19ca6a19f7a3410cdde14ea 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
@@ -109,7 +109,7 @@ bool CSSParser::parseSupportsCondition(const String& condition)
return CSSSupportsParser::supportsCondition(scope.tokenRange(), parser) == CSSSupportsParser::Supported;
}
-bool CSSParser::parseColor(RGBA32& color, const String& string, bool strict)
+bool CSSParser::parseColor(Color& color, const String& string, bool strict)
{
if (string.isEmpty())
return false;
@@ -118,7 +118,7 @@ bool CSSParser::parseColor(RGBA32& color, const String& string, bool strict)
// handle these first.
Color namedColor;
if (namedColor.setNamedColor(string)) {
- color = namedColor.rgb();
+ color = namedColor;
return true;
}
@@ -133,7 +133,7 @@ bool CSSParser::parseColor(RGBA32& color, const String& string, bool strict)
return true;
}
-bool CSSParser::parseSystemColor(RGBA32& color, const String& colorString)
+bool CSSParser::parseSystemColor(Color& color, const String& colorString)
{
CSSParserString cssColor;
cssColor.init(colorString);
@@ -141,8 +141,7 @@ bool CSSParser::parseSystemColor(RGBA32& color, const String& colorString)
if (!CSSPropertyParser::isSystemColor(id))
return false;
- Color parsedColor = LayoutTheme::theme().systemColor(id);
- color = parsedColor.rgb();
+ color = LayoutTheme::theme().systemColor(id);
return true;
}
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParser.h ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698