Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: chrome/browser/ui/browser.cc

Issue 139983006: [DevTools] Handle frontend zoom similarly to tab zoom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 87acf52c3f42ef8b404ee151571318bd5cbfd81b..6540dd3b999daabf4f1f0ad0f1eaeeb8a24e9e90 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1765,7 +1765,8 @@ void Browser::OnZoomChanged(content::WebContents* source,
bool can_show_bubble) {
if (source == tab_strip_model_->GetActiveWebContents()) {
// Only show the zoom bubble for zoom changes in the active window.
- window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive());
+ window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive() &&
+ SupportsWindowFeature(FEATURE_LOCATIONBAR));
vsevik 2014/02/12 15:13:43 This will disable zoom bubble for Chrome Apps. I d
jochen (gone - plz use gerrit) 2014/02/12 15:17:42 I agree, this should be addressed before we land t
dgozman 2014/02/12 16:27:16 Apps don't have zoom, and they have not decided ye
vsevik 2014/02/13 08:02:26 I agree that DevTools do not need UI for zoom (we
dgozman 2014/02/13 10:08:25 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698