[DevTools] Handle frontend zoom similarly to tab zoom.

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 1747 matching lines @@
     window_->SetStarredState(starred);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, ZoomObserver implementation:
 
 void Browser::OnZoomChanged(content::WebContents* source,
                             bool can_show_bubble) {
   if (source == tab_strip_model_->GetActiveWebContents()) {
     // Only show the zoom bubble for zoom changes in the active window.
-    window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive());
+    window_->ZoomChangedForActiveTab(can_show_bubble && window_->IsActive() &&
+        SupportsWindowFeature(FEATURE_LOCATIONBAR));

[vsevik, 2014/02/12 15:13:43]

This will disable zoom bubble for Chrome Apps.
I don't think you should do this, we should fix how it looks when there is no
location bar instead.

[jochen (gone - plz use gerrit), 2014/02/12 15:17:42]

I agree, this should be addressed before we land this

[dgozman, 2014/02/12 16:27:16]

Apps don't have zoom, and they have not decided yet on the UI. See
crbug.com/227175.

Undocked DevTools is the only case here right now, and it's ok without UI
indication. I've added a comment explaining.

Fixing this for Apps (which seems like a thing apps team will definitely do)
will also improve DevTools case.

[vsevik, 2014/02/13 08:02:26]

I agree that DevTools do not need UI for zoom (we didn't have it before and can
add one in the frontend if needed).
Let's disable it for DevTools explicitly then. (&& !is_devtools())

[dgozman, 2014/02/13 10:08:25]

Done.

   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, ui::SelectFileDialog::Listener implementation:
 
 void Browser::FileSelected(const base::FilePath& path, int index,
                            void* params) {
   FileSelectedWithExtraInfo(ui::SelectedFileInfo(path, path), index, params);
 }
@@ skipping 521 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }