Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1399743002: Straw man setExceptionPauseMode (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
turnidge, rmacnak, danrubel
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -33 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_exceptions_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 2 chunks +28 lines, -20 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Cutch
5 years, 2 months ago (2015-10-09 14:08:31 UTC) #2
danrubel
https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service/service.md#newcode41 runtime/vm/service/service.md:41: - [setExceptionPauseMode](#setexceptionpausemode) Indent?
5 years, 2 months ago (2015-10-09 19:16:31 UTC) #4
Cutch
On 2015/10/09 19:16:31, danrubel wrote: > https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service/service.md > File runtime/vm/service/service.md (right): > > https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service/service.md#newcode41 > ...
5 years, 2 months ago (2015-10-09 21:06:26 UTC) #5
turnidge
https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service.cc#newcode3270 runtime/vm/service.cc:3270: set_exception_pause_mode_params }, There should be a way to read ...
5 years, 2 months ago (2015-10-12 16:43:51 UTC) #6
Cutch
https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/1399743002/diff/20001/runtime/vm/service.cc#newcode3270 runtime/vm/service.cc:3270: set_exception_pause_mode_params }, On 2015/10/12 16:43:51, turnidge wrote: > There ...
5 years, 2 months ago (2015-10-12 17:51:43 UTC) #7
turnidge
lgtm
5 years, 2 months ago (2015-10-12 18:00:48 UTC) #8
Cutch
5 years, 2 months ago (2015-10-12 18:04:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9dd7680fd821d4f78f869e7087160d7c0e62ab8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698